Add reproducer for possible issue with object return type inheritance #6961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
force-pushed
the
object-return-inheritance-bug
branch
from
b222104 to
b928ee1
Compare
|
I've addressed part of the issue in 7fbfcfa. |
nikic
reviewed
May 10, 2021
krakjoe
force-pushed
the
object-return-inheritance-bug
branch
from
b1d59c2 to
403eebf
Compare
nikic
reviewed
May 10, 2021
nikic
reviewed
May 10, 2021
nikic
reviewed
May 10, 2021
nikic
approved these changes
May 10, 2021
|
Thank you both for taking care of this issue! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, a reproducer is the most I could find out with regard to this issue, which I noticed while working on #6548.
If a method with a declared return type (e.g.
mixed,object) is overridden with a class return type (e.g.stdClass), then there's a segfault somewhere in a very early stage, so not even an empty PHP script runs.Although the issue is reproduced via
ReflectionEnumUnitCase::getValue()which overridesReflectionClassConstant::getValue()- I only had to add amixedreturn type to the parent method -, but it is not limited to this case only. So I could trigger the same issue with other classes.